Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal color update #176

Closed
ykamendrovskiy opened this issue Jun 1, 2022 · 0 comments · Fixed by #195
Closed

Modal color update #176

ykamendrovskiy opened this issue Jun 1, 2022 · 0 comments · Fixed by #195
Assignees

Comments

@ykamendrovskiy
Copy link

ykamendrovskiy commented Jun 1, 2022

All the floating items now have the same color --yc-color-base-float but in fact we have two classes of float items — modals and popups. Modals are the ones displayed on top of a veil thet mutes the page. And popups are the ones with a shadow like lists in selects, suggests etc.

In dark mode all the backgrounds are dark and in some modals we display popups and the shadow doesn't work well to separate these items.

So, let's have another semantic variable for the modals — all the floating components with a veil.

  1. Let's create a new semantic variable --yc-color-base-modal
  • light theme: --yc-color-private-white-1000
  • dark theme: --yc-color-private-black-rock-850
  1. Let's assign this variable as a background for the modal

  2. Let's change the veil color --yc-color-sfx-veil in dark theme to optimize modal readability

  • add new private variable --yc-color-private-black-600 with value rgba(0, 0, 0, .6)
  • assign this variable as a value in dark theme
@amje amje self-assigned this Jun 15, 2022
@amje amje closed this as completed in #195 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants