feat(RadioGroup): improve radio-group components a11y #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
ogonkov
reviewed
Jun 18, 2022
| @@ -14,10 +14,12 @@ const options: RadioButtonOption[] = [ | |||
| {value: 'Value 3', content: 'Value 3'}, | |||
| ]; | |||
|
|
|||
| const DefaultTemplate: Story<RadioButtonProps> = (args) => <RadioButton {...args} />; | |||
| const DefaultTemplate: Story<RadioButtonProps> = (args) => { | |||
| const [value, setValue] = React.useState<string>(options[0].value); | |||
There was a problem hiding this comment.
Why not use storybook controls?
There was a problem hiding this comment.
Is it able to set control value from callback? Otherwise example wont be interactive.
There was a problem hiding this comment.
Nope, storybook is not intended to be interactive, it is more like UI snapshots than demos.
There was a problem hiding this comment.
It's kinda weird when you open a demo and it's not working properly. And the only way to change the value is to do it by hand.
amje
force-pushed
the
radio-button-focus
branch
from
0c438d3
to
4b5df18
Compare
|
Preview is ready. |
amje
changed the title
ogonkov
reviewed
Jan 20, 2023
Comment on lines
+44
to
+45
| 'aria-label': props['aria-label'], | ||
| 'aria-labelledby': props['aria-labelledby'], |
There was a problem hiding this comment.
if aria-label set, aria-labelledby should not be setted
ogonkov
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #179