Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Toaster)!: rename timeout to autoHiding #248

Merged
merged 5 commits into from
Dec 28, 2022
Merged

Conversation

ogonkov
Copy link
Contributor

@ogonkov ogonkov commented Jul 18, 2022

Fixes #241

@yc-ui-bot
Copy link
Contributor

Preview is ready.

@ogonkov ogonkov changed the title feat(Toaster): remove allowAutoHiding in favour of timeout feat(Toaster)!: remove allowAutoHiding in favour of timeout Jul 20, 2022
@ogonkov ogonkov changed the base branch from main to next December 19, 2022 22:55
@ogonkov ogonkov force-pushed the feat/toast_autohiding branch 2 times, most recently from fef4ca8 to f91d658 Compare December 19, 2022 23:05
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@ogonkov ogonkov marked this pull request as ready for review December 19, 2022 23:06
@amje
Copy link
Contributor

amje commented Dec 23, 2022

@ogonkov What do you think about using 0 instead of null?

@ogonkov
Copy link
Contributor Author

ogonkov commented Dec 23, 2022

Yes, i think it will work

@ogonkov ogonkov changed the title feat(Toaster)!: remove allowAutoHiding in favour of timeout feat(Toaster)!: rename timeout to hideAfter Dec 27, 2022
@ogonkov ogonkov changed the title feat(Toaster)!: rename timeout to hideAfter feat(Toaster)!: rename timeout to autoHiding Dec 28, 2022
@ogonkov ogonkov merged commit 36ccc34 into next Dec 28, 2022
@ogonkov ogonkov deleted the feat/toast_autohiding branch December 28, 2022 11:57
amje pushed a commit that referenced this pull request Jan 12, 2023
* `timeout` renamed to `autoHiding`
* `allowAutoHiding` option removed, use `autoHiding=false` instead
ValeraS pushed a commit that referenced this pull request Jan 17, 2023
* `timeout` renamed to `autoHiding`
* `allowAutoHiding` option removed, use `autoHiding=false` instead
amje pushed a commit that referenced this pull request Jan 20, 2023
* `timeout` renamed to `autoHiding`
* `allowAutoHiding` option removed, use `autoHiding=false` instead
amje pushed a commit that referenced this pull request Jan 26, 2023
* `timeout` renamed to `autoHiding`
* `allowAutoHiding` option removed, use `autoHiding=false` instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove allowAutoHiding from <Toast/>
4 participants