fix(DropdownMenu.Item): allow usage w/out text
#406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
axtk
requested changes
Dec 6, 2022
|
|
||
| type Props<T> = DropdownMenuItemType<T> & { | ||
| children?: ReactNode; | ||
| type Props<T> = Omit<MenuItemProps, 'onClick'> & { |
There was a problem hiding this comment.
these changes should be made on the exported props type in ./types
axtk
reviewed
Dec 8, 2022
| type Props<T> = DropdownMenuItemType<T> & { | ||
| children?: ReactNode; | ||
| }; | ||
| type Props<T> = Omit<MenuItemProps, 'onClick'> & Partial<DropdownMenuItemRequiredProps<T>>; |
There was a problem hiding this comment.
if the original DropdownMenuItem type changes in the way it picks props from MenuItemProps or some other way, we'll have to sync it with this type, which is inconvenient, if not a source of errors
why not do exactly what the title of the PR reads:
type Props<T> = Omit<DropdownMenuItem<T>, 'text'> & {
text?: DropdownMenuItem<T>['text'];
children?: ReactNode;
};There was a problem hiding this comment.
This is resolves text as required
There was a problem hiding this comment.
it's strange, tried it out, seems to work
can you show your code?
There was a problem hiding this comment.
seems like i was confused by some WS checks
ogonkov
force-pushed
the
fix/dropdown/item_types
branch
from
07f6ced
to
383bb9d
Compare
axtk
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.