Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Sheet and PromoSheet components #435

Closed
amje opened this issue Dec 21, 2022 · 2 comments
Closed

Refactor Sheet and PromoSheet components #435

amje opened this issue Dec 21, 2022 · 2 comments
Assignees
@mournfulCoroner

Comments

@amje
Copy link
Contributor

amje commented Dec 21, 2022

These components were migrated "as is" from internal codebase. We should change theirs code and api in uikit way
@korvin89
Copy link
Contributor

korvin89 commented Jun 23, 2023 •
edited by amje
Loading

Sheet component:

  1. Rewrite as functional component
  2. Use this lib for swipe actions

PromoSheet component: move to components (done)

@korvin89 korvin89 assigned mournfulCoroner and unassigned korvin89 Feb 14, 2024
@korvin89
Copy link
Contributor

Fixed here #1268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mournfulCoroner mournfulCoroner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amje @korvin89 @mournfulCoroner