Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): add row actions size control prop #557

Merged
merged 6 commits into from
Mar 3, 2023

Conversation

calaquend1
Copy link
Contributor

No description provided.

@calaquend1 calaquend1 requested a review from axtk as a code owner March 3, 2023 11:03
@calaquend1 calaquend1 requested a review from amje March 3, 2023 11:03
src/components/DropdownMenu/DropdownMenu.tsx Outdated Show resolved Hide resolved
@calaquend1 calaquend1 requested review from amje and removed request for axtk March 3, 2023 12:02
@amje
Copy link
Contributor

amje commented Mar 3, 2023

@calaquend1 Let's also add text about new prop in docs

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

src/components/Table/README.md Outdated Show resolved Hide resolved
@@ -112,7 +112,7 @@ const WithTableActionsTemplate: Story<TableProps<DataItem>> = (args) => {
},
},
];
return <TableWithAction {...args} getRowActions={getRowActions} />;
return <TableWithAction {...args} rowActionsSize="l" getRowActions={getRowActions} />;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep the default size here

@amje amje changed the title feat: add actions button size control prop feat(Table): add row actions size control prop Mar 3, 2023
@amje amje merged commit a045e12 into gravity-ui:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants