Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Select): add "open", "toggleOpen" props #558

Merged
merged 22 commits into from
Mar 7, 2023
Merged

feat(Select): add "open", "toggleOpen" props #558

merged 22 commits into from
Mar 7, 2023

Conversation

imechoim
Copy link
Contributor

@imechoim imechoim commented Mar 3, 2023 •
edited
Loading

  1. Add controlled open prop.
  2. onOpenChange will be called when open changes. (works for controlled and uncontrolled open prop)
  3. introduce toggleOpen. Accept open value or inverts current.
  4. setOpen marked as deprecated

Closes #553
Closes #552

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@imechoim imechoim changed the title Add force close method in Select feat(Select): add open, onClose props Mar 3, 2023
@imechoim imechoim changed the title feat(Select): add open, onClose props feat(Select): add "open", "onClose" props Mar 3, 2023
korvin89
korvin89 reviewed Mar 5, 2023
View reviewed changes
src/components/Select/types.ts Outdated Show resolved Hide resolved
src/components/utils/useSelect/useOpenState.ts Outdated Show resolved Hide resolved
src/components/utils/useSelect/useOpenState.ts Outdated Show resolved Hide resolved
src/components/utils/useSelect/__tests__/useOpenState.test.tsx Outdated Show resolved Hide resolved
@korvin89
Copy link
Contributor

korvin89 commented Mar 5, 2023

Add this properties to readme file please

@imechoim imechoim changed the title feat(Select): add "open", "onClose" props feat(Select): add "open", "toggleOpen" props Mar 7, 2023
ValeraS
ValeraS requested changes Mar 7, 2023
View reviewed changes
src/components/Select/Select.tsx Outdated Show resolved Hide resolved
src/components/Select/Select.tsx Outdated Show resolved Hide resolved
src/components/utils/useSelect/useOpenState.ts Outdated Show resolved Hide resolved
src/components/utils/useSelect/useOpenState.ts Outdated Show resolved Hide resolved
@imechoim imechoim merged commit 43d130f into main Mar 7, 2023
@imechoim imechoim deleted the select-controlled-open branch March 7, 2023 18:20
@gravity-ui-bot gravity-ui-bot mentioned this pull request Mar 7, 2023
Merged
@gravity-ui-bot gravity-ui-bot mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValeraS ValeraS ValeraS approved these changes

@korvin89 korvin89 korvin89 approved these changes

@amje amje Awaiting requested review from amje amje is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add force close method in Select Improve typings in Select
4 participants
@imechoim @gravity-ui-bot @korvin89 @ValeraS