fix(layout/Flex): fix gap size values and remove default theme spacin… #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaevAlexandr
force-pushed
the
fix/flex-gap-sizes
branch
from
71c6bf9
to
832fee0
Compare
|
Preview is ready. |
IsaevAlexandr
commented
Mar 30, 2023
|
|
||
| if (typeof space === 'object') { | ||
| s = getClosestMediaProps(space) || themeFlexProps.space; |
There was a problem hiding this comment.
implicit use of context was a bad design decision. Looking at the code, we must clearly understand what size is currently used in the code
amje
approved these changes
Mar 31, 2023
IsaevAlexandr
force-pushed
the
fix/flex-gap-sizes
branch
from
832fee0
to
ca80234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gs from Flex