feat(Popover): let action and cancel buttons to wrap on long text #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
preview with popover: https://preview.gravity-ui.com/uikit/631/?path=/story/components-popover--full-featured |
ogonkov
reviewed
Apr 18, 2023
kseniya57
approved these changes
Apr 19, 2023
|
@gearoffortune Can you add story with buttons with long text please? |
https://preview.gravity-ui.com/uikit/631/?path=/story/components-popover--with-long-action-items |
ogonkov
reviewed
Apr 19, 2023
src/components/Popover/Popover.scss
Outdated
| } | ||
|
|
||
| &-button { | ||
| margin: 5px; |
There was a problem hiding this comment.
It's better to add at least sass var for this value
|
The buttons are moved towards left a bit
|
ogonkov
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the buttons with long text will just break the container
This pull request fixes this behavour by letting the buttons to wrap and to turn into a coloumn