-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Popover): let action and cancel buttons to wrap on long text #631
Conversation
Preview is ready. |
preview with popover: https://preview.gravity-ui.com/uikit/631/?path=/story/components-popover--full-featured |
@gearoffortune Can you add story with buttons with long text please? |
https://preview.gravity-ui.com/uikit/631/?path=/story/components-popover--with-long-action-items |
src/components/Popover/Popover.scss
Outdated
} | ||
|
||
&-button { | ||
margin: 5px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to add at least sass var for this value
Currently, the buttons with long text will just break the container
This pull request fixes this behavour by letting the buttons to wrap and to turn into a coloumn