feat(TextInput): add an option to display error via tooltip #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ilya-878
commented
Jul 17, 2023
ilya-878
commented
- Add 3 new props for TextInput component (errorMessage, errorPlacement, validationState) and 2 new props for TextArea component (errorMessage, validationState).
- Create errorPropsMapper function that updates new props based on the deprecated prop (error).
- Add error-in-tooltip feature for TextInput component.
- Write few tests for new props for both components.
- Add few error examples to the TextInputShowcase.
- Mark 'error' prop as deprecated.
…or via tooltip for TextInput
|
Preview is ready. |
korvin89
reviewed
Jul 18, 2023
src/components/controls/TextInput/__tests__/TextInput.input.test.tsx
Outdated
Show resolved
Hide resolved
amje
requested changes
Aug 4, 2023
mfyodorov
approved these changes
Aug 25, 2023
added 2 commits
August 31, 2023 15:35
amje
changed the title
amje
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.