-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TextArea, TextInput): use aria-describedby for error and note #904
Conversation
Preview is ready. |
4eadbab
to
f7b36f8
Compare
Could U add this changes to TextArea too? |
f7b36f8
to
309dae9
Compare
Ready |
0ad03e0
to
559420c
Compare
dda7e15
to
20e57fc
Compare
src/components/controls/TextInput/__tests__/TextInput.input.test.tsx
Outdated
Show resolved
Hide resolved
20e57fc
to
e91067e
Compare
a7d016b
to
c504366
Compare
30eb07a
to
461e1a2
Compare
@@ -46,31 +46,6 @@ $block: '.#{variables.$ns-new}text-area'; | |||
} | |||
} | |||
|
|||
&__outer-additional-content { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also remove styles from 'TextInput.scss'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course. Missed
controlProps: { | ||
...controlProps, | ||
'aria-describedby': ariaDescribedBy || undefined, | ||
'aria-invalid': Boolean(error) || undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check validationState
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right
0312d3f
to
0667d95
Compare
closes #860