feat(TextArea, TextInput): use aria-describedby for error and note #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
Kyzyl-ool
changed the title
Kyzyl-ool
force-pushed
the
feat/a11y-improvements
branch
2 times, most recently
from
4eadbab
to
f7b36f8
Compare
|
Could U add this changes to TextArea too? |
Kyzyl-ool
force-pushed
the
feat/a11y-improvements
branch
from
f7b36f8
to
309dae9
Compare
Ready |
ValeraS
requested changes
Aug 22, 2023
Kyzyl-ool
force-pushed
the
feat/a11y-improvements
branch
3 times, most recently
from
0ad03e0
to
559420c
Compare
Kyzyl-ool
force-pushed
the
feat/a11y-improvements
branch
3 times, most recently
from
dda7e15
to
20e57fc
Compare
ValeraS
requested changes
Aug 26, 2023
src/components/controls/TextInput/__tests__/TextInput.input.test.tsx
Outdated
Show resolved
Hide resolved
Kyzyl-ool
force-pushed
the
feat/a11y-improvements
branch
from
20e57fc
to
e91067e
Compare
Kyzyl-ool
force-pushed
the
feat/a11y-improvements
branch
from
a7d016b
to
c504366
Compare
ValeraS
approved these changes
Sep 1, 2023
Kyzyl-ool
force-pushed
the
feat/a11y-improvements
branch
3 times, most recently
from
30eb07a
to
461e1a2
Compare
amje
requested changes
Sep 5, 2023
| @@ -46,31 +46,6 @@ $block: '.#{variables.$ns-new}text-area'; | |||
| } | |||
| } | |||
|
|
|||
| &__outer-additional-content { | |||
There was a problem hiding this comment.
Shouldn't we also remove styles from 'TextInput.scss'?
| controlProps: { | ||
| ...controlProps, | ||
| 'aria-describedby': ariaDescribedBy || undefined, | ||
| 'aria-invalid': Boolean(error) || undefined, |
There was a problem hiding this comment.
We should check validationState instead
added 12 commits
September 5, 2023 17:24
Kyzyl-ool
force-pushed
the
feat/a11y-improvements
branch
from
0312d3f
to
0667d95
Compare
amje
approved these changes
Sep 5, 2023
amje
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #860