Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create useViewportSize hook #933

Merged
merged 2 commits into from
Aug 24, 2023
Merged

feat: create useViewportSize hook #933

merged 2 commits into from
Aug 24, 2023

Conversation

NikitaCG
Copy link
Contributor

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

amje
amje requested changes Aug 23, 2023
View reviewed changes
src/hooks/UseViewportSize/index.ts Outdated
@@ -0,0 +1,2 @@
export {useViewportSize} from './UseViewportSize';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's place this hook with others, inside utils directory, we will refactor directory structure later. Also the file should be named in lowercase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@NikitaCG NikitaCG force-pushed the feat/add-hook-use-viewport-size branch from 7aa30b5 to 506ba92 Compare August 23, 2023 12:41
@NikitaCG NikitaCG force-pushed the feat/add-hook-use-viewport-size branch 4 times, most recently from a9687d6 to 7dd2769 Compare August 24, 2023 10:34
@NikitaCG NikitaCG force-pushed the feat/add-hook-use-viewport-size branch from 7dd2769 to e9b1376 Compare August 24, 2023 10:44
@NikitaCG NikitaCG merged commit 637f88d into main Aug 24, 2023
3 checks passed
@NikitaCG NikitaCG deleted the feat/add-hook-use-viewport-size branch August 24, 2023 10:47
@gravity-ui-bot gravity-ui-bot mentioned this pull request Aug 24, 2023
Merged
@gravity-ui-bot gravity-ui-bot mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amje amje amje approved these changes

@ValeraS ValeraS Awaiting requested review from ValeraS ValeraS is a code owner

@korvin89 korvin89 Awaiting requested review from korvin89 korvin89 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikitaCG @gravity-ui-bot @amje