feat: Support revoke command/grant command improvements for Clickhouse #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viladimiru
changed the title
viladimiru
force-pushed
the
feat/support-revoke-rule
branch
from
21d5325
to
e3cd938
Compare
viladimiru
changed the title
viladimiru
changed the title
NikitaShkaruba
approved these changes
Oct 21, 2024
| : GRANT clusterClause? privilegeList ON grantSubjectIdentifier TO userOrRoleExpressionList (WITH GRANT OPTION)? (WITH REPLACE OPTION)? | ||
| | GRANT clusterClause? roleIdentifier TO userOrRoleExpressionList (WITH ADMIN OPTION)? (WITH REPLACE OPTION)? | ||
| : GRANT clusterClause? (privilegeList ON grantSubjectIdentifier) (COMMA privilegeList ON grantSubjectIdentifier)* TO userOrRoleExpressionList (WITH GRANT OPTION)? (WITH REPLACE OPTION)? | ||
| | GRANT clusterClause? roleExpressionList TO userOrRoleExpressionList (WITH ADMIN OPTION)? (WITH REPLACE OPTION)? | ||
| | GRANT CURRENT GRANTS ((LPAREN privilegeList ON grantSubjectIdentifier RPAREN) | ON grantSubjectIdentifier) TO userOrRoleExpressionList (WITH GRANT OPTION)? (WITH REPLACE OPTION)? | ||
| ; | ||
|
|
||
| grantSubjectIdentifier |
There was a problem hiding this comment.
nit: Let's rename it to accessSubjectIdentifier? It's being used in revoke
| : GRANT clusterClause? privilegeList ON grantSubjectIdentifier TO userOrRoleExpressionList (WITH GRANT OPTION)? (WITH REPLACE OPTION)? | ||
| | GRANT clusterClause? roleIdentifier TO userOrRoleExpressionList (WITH ADMIN OPTION)? (WITH REPLACE OPTION)? | ||
| | GRANT CURRENT GRANTS ((LPAREN privilegeList ON grantSubjectIdentifier RPAREN) | ON grantSubjectIdentifier) TO userOrRoleExpressionList (WITH GRANT OPTION)? (WITH REPLACE OPTION)? | ||
| : GRANT clusterClause? (privilegeList ON accessSubjectIdentifier) (COMMA privilegeList ON accessSubjectIdentifier)* TO userOrRoleExpressionList (WITH GRANT OPTION)? (WITH REPLACE OPTION)? |
There was a problem hiding this comment.
nit: I think we can move out WITH REPLACE OPTION, it is copy pasted multiple times
| expect(autocompleteResult.errors).toHaveLength(0); | ||
| }); | ||
|
|
||
| test('should not report errors', () => { |
There was a problem hiding this comment.
I'd give these tests different names, because if one of them fails it will be hard to understand which one
viladimiru
force-pushed
the
feat/support-revoke-rule
branch
from
8e09e1f
to
5472325
Compare
roberthovsepyan
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.