Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render icon and icon+text for large POIs on lower zoom levels #1057

Open
matkoniecz opened this issue Oct 13, 2014 · 4 comments
Open

render icon and icon+text for large POIs on lower zoom levels #1057

matkoniecz opened this issue Oct 13, 2014 · 4 comments

Comments

@matthijsmelissen
Copy link
Collaborator

I have been experimenting with this, but it gives some unexpected results.

  • Loads of car shop icons showing up at low zoom, and little other shops.
  • With threshold 750 pixels, on z16, only some clothes shops show up, while their is still loads of empty space. Showing only some clothes shops gives the impression that there are only a handful of clothes shops in the city. Same for other POI.

I think we should keep rendering all POI on z17, because z18 is too late for small rural shops.

What would you use as threshold? I think 3000 pixels (the threshold for labels) is too high for this to have any effect, because hardly any POI reaches 3000 pixels before z17.

@matthijsmelissen
Copy link
Collaborator

Also note that 67 % van of the supermarkets and 62 % of the department stores are tagged as node only.

@pnorman
Copy link
Collaborator

pnorman commented Oct 15, 2014

I have been experimenting with this, but it gives some unexpected results.

Loads of car shop icons showing up at low zoom, and little other shops.
With threshold 750 pixels, on z16, only some clothes shops show up, while their is still loads of empty space. Showing only some clothes shops gives the impression that there are only a handful of clothes shops in the city. Same for other POI.
I think we should keep rendering all POI on z17, because z18 is too late for small rural shops.

What would you use as threshold? I think 3000 pixels (the threshold for labels) is too high for this to have any effect, because hardly any POI reaches 3000 pixels before z17.

I think the basic problem is that buildings with multiple POIs within are generally mapped as nodes inside of the building way, and these will have zero area. I could see adding rendering at lower zooms to large features, but I don't think we want to take away at higher zooms.

This will also tend to render more car shops, as they often have an outside lot which is part of the shop (e.g. http://www.openstreetmap.org/way/158991197) while most shops are just inside. You'll also see more shops of types which tend to be large freestanding buildings, e.g. supermarkets and theaters. This is probably okay, as they tend to be more significant.

@matthijsmelissen
Copy link
Collaborator

I don't think we want to take away at higher zooms.

Not sure if I agree - I don't think taking away small museums from z16 would be bad, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants