-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
building=house and building=garage should render in slightly different colours #1207
Comments
It was more just something that was carried forwards for historical reasons.
Not doing the old confusing logic for rendering some types of buildings lighter was intentional. |
I never understood building=house being lighter - i could just about understand garages. |
Have a look at http://overpass-turbo.eu/s/6VR or http://overpass-turbo.eu/s/6VT or many other areas with lots of sheds. See also #568 for some old screenshots with a tweaked rendering. This is of course a subjective, but I feel it makes things significantly clearer. In areas with lots of "light buildings" (for lack of a better name) they tend to distract the eye, and rendering them differently fixes that (just as rendering churches and important amenities is usefull). Rendering building types differently also shows off osm's richeness and encourages mappers to not mindlessly use building=yes. That was actually my main and early complain about the big building restyling (which I otherwise love): getting rid of the "confusing" (I though #490 made the list much more logical ?) concept of light buildings, and making the default buildings so light to begin with that anything lighter will be almost white. It made sense to not delay the big building restyling PR with a request to keep light buildings, but I always expected to bring them back at some stage. |
@mkoniecz, I noticed while working on an area of Wuerzburg, Germany where the buildings had been drawn, but the housenumbers not yet collected. In particular this is an area of low-density detached housing, where there's roughly a 1:1 ratio of houses to double garages---which lots of "randomly" placed:
Having the house numbers allows some differientation (when housenumbers have been added, and at those zoom levels), but without we have what appears to be a sea of blobs. I can also affirm to what @vincentdephily and @Rovastar have noted, there is a feedback loop between demonstrating that OSM has richer data, and people using building=* descriptively. Indeed, seeing the contrast between building=house vs. building={garage{,s},shed} was the motivator for adding garages and tagging them. |
+1 for having more differentiation in buildings. There could be 3 tiers:
|
Nice idea. Do you think the lower importance buildings should be rendered like building=roof, but with no transparency, or would you like it to be one more rendering type? |
Doesn't building=roof render exactly like all other buildings now? There is no transparency anymore. I believe we can't really make buildings lighter than they are at the moment, so the current version would be the new "light". The new "normal" would need to be a bit stronger. #1208 is related, but the suggestions there are still very close to the current colour. If we want to differentiate, there should probably be a bit more distance. Maybe a stronger outline for the "normal" buildings is enough? #490 has a good list of buildings that were rendered light:
|
Regarding lighter-than-light we don't need to compare those solely against whiteness. Houses and garages normally occur drawn over landuse=residential, so one can optimise for ensuring contrast in the common case. So this would be optimising constrast between building=house/apartments vs. building=shed/greenhouse/conservatory/garage/garages/roof vs. building=*; all when drawn over landuse=residential. |
Oh, that's pity... Some large scale roofs should enable user to see the area under them. |
One of the goals of the restyling was to move away from building transparency altogether. It makes sense in particular with landuse, which have lots of different hues, and with some buildings being only partially over a particular landuse (that's typical when going from residential to commercial, the area often doesn't follow building outlines exactly). As far as I know there isn't an easy way to, for example, see highway=service through a building but not landuse=*. You have to render a tinted version of the highway over the building, which is fiddly work. |
No comment... building=roof : |
@mboeringa, if you were to [edit] the comment and describe the issue in textual form, this would be useful. |
It is not an issue, it is a possible solution to the questions, doubts and remarks I quoted. I have presented this before here somewhere on the issue tracker. It is at least one possible way of rendering building=roof without the need of transparency and all the difficulties in interpretation of mixed colors it causes. I just used a very fine open neutral grey crossed hatch to represent roofs, allowing you to "see through", and render it on top of everything else. |
I fear the talk of transparency may have got this side-tracked over the last few months. In-lieu of other suggestions, moving building=shed/garage to the colour of amenities/places_of_worship would restore some form of contrast in residential areas, even if it's the other way around. This would also make that the buildings more likely to have written text in them (houses with house numbers) have good contrast between fill-colour and text-colour. |
sent from a phone
please not, wouldn't make any sense, if we want to do something we should rather lower the visual impact of garages, not raise it. Place of worship buildings are darker because they are generally important, also historically, while garages are typically less important than the buildings they serve. |
I didn't realize this issue was still open. Changing this is technically fairly easy, so if someone wants to propose a change in a PR they're welcome to, but I'm going to close this since I think we're happy with the current state of building rendering. If someone needs a residential area with a bunch of houses and garages, http://www.openstreetmap.org/#map=18/49.21593/-122.91540 has both mapped in some detail. |
To clarify, I do not consider the current situation a bug. As with any issue, views could change with a convincing demonstration of suitable changes. |
@pnorman: Thanks for the clarification, and the reiteration that this is waiting on a CartoCSS/Pull Request of a workable solution to the lack of contrast. There's probably a conflict here in how to potentially restore the contrast between:
In these cases, @daganzdaanda was suggesting three levels of building. A further possible solution would be to adjust the rendering of the outline of the buildings; so perhaps rendering lower priority "background" buildings with just the fill and without a contrast on the edge. The later might possibly meet both of the seemingly conflicting proposals, whilst also re-achieving some level of contrast based on the usage classification. |
Any potential fix can probably fix issue #738 ( |
I worked toward improving the set and styling of "minor" buildings in the past, and still think that osm-carto should distinguish them. But I don't have time to write a PR at the moment :/ |
I have found this issue because I'm mapping a research facility with numerous building=shed. The lack of differentiation between substantial buildings and less-substantial structures such as sheds makes the rendering a bit hard to visually scan, in my opinion. I remembered that garages were rendered lighter, a detail I liked, which is why I came to search here - though IIUC the differentiation is not in the current render at all (not for garages either). So this is just one vote from me with an example, for a mildly-differentiated rendering for auxiliary buildings. |
@danstowell while I agree that distinction would be nice, I don't think it is possible with a long tail of the current building=* tag or with only one tag: Peter made some analysis in the past (2012) of the long tail and possible solutions: Note that his definitions are actually belong to http://taginfo.openstreetmap.org/keys/building%3Ause tag, not a building=* tag (a building typology). Instead, we can render building:levels=1 ...2 buildings differently from others. This approach is easier to add in database and to implement and use/read (not to classify 30-100 building typology tags) |
It is useful to be able to tell the houses from the garages and traditionally slightly different shades have been used for building=house and building=garage/building=garages. This is because it makes residential areas more readable.
Recently (early January 2015) a change appears to have been made to lighten buildings, and now garages and houses are the same colour. This change is probably quite recent because some tiles have it and some don't.
I can't see anything explicit in the changelog, so this is probably more likely to be an accidental regression. Likely from commit 01acfb1
The text was updated successfully, but these errors were encountered: