-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render label for historic=city_gate #152
Comments
Can you give examples of city gates that should be rendered and tourism=attraction is not applicable? example: http://www.openstreetmap.org/?mlat=50.06490&mlon=19.94135#map=19/50.06490/19.94135 - name gets rendered thanks to tourism=attraction. |
2014/1/17 Bulwersator [email protected]
|
I dunno, from reading http://en.wikipedia.org/wiki/Porta_Metronia - historic=yes+description? would perhaps be better (assuming the name got rendered from that tagging) |
"adding tourism=attraction to what should be rendered is not the way I think the map should work ;-)" Yes, but adding tourism=attraction to tourism attractions is a good idea. But I see that Porta Metronia maybe should not be tagged this way (what is quite funny as in my country any building that survived 1700 years would be instantly a major tourist attraction). But I see even better reason to render tag in this case - existing wikipedia tag - what I reported as #317 (Render names for objects with wikipedia tag). |
2014/1/18 CloCkWeRX [email protected]
why would it be better to change the tagging from something explicitly After all, city gates are a very common and very important feature. Even if For everyone mapping in historical context this is (or should be) a main |
see also #790 proposing doing this for barrier=gate |
Yes, while gates should also have their name rendered (in the few cases where a name tag is present), it's worth to point out that historic=city_gate might also be applied to places without actual gates (still the name will typically be preserved, and in a lot of cases there will be traces, e.g. an opening in the city wall). |
Are we still interested in this? How should it be rendered then? |
I’d render just a label, these are typically well known toponyms even in absence of the actual gate / structure
|
There is also icon in Osmic - one should test if and when (probably z18+/z19+) to render it: https://github.com/gmgeo/osmic/blob/master/tourism/city-gate-14.svg |
This is one of the oldest issues, and relatively simple to implement. Is anyone willing to work on this? |
Is this something for @andrzej-r perhaps? |
with the Osmic icon: on building: |
What about man-made grey for this feature? It would match city walls then, which often city gates are connected with. I would also like to see test renderings with just a label to compare. |
with man_made colour on same locations: label is not displayed for the previous one (priority of street name ?). Adjacent gate: I'm in favour for man_made colour which is also consistent with defensive towers |
+1 to the version with icon.
|
Man made black is consistent with all the towers and city walls, so I vote for this color too. @jragusa Could you prepare a PR? |
Lighter icon might also work for castles/palaces/stately/manors etc. - but somebody has to test it. There's also a question how the Relations might not work because currently import using osm2pgsql does not move relation properties to their members. |
these gates are tagged as multipolygons, right? In that case no special handling is needed (as long as labels for areas are displayed). |
City gates are mostly quite important features for orientation. Even if the citywalls or the city gate doesn't exist (or act as barriers) any more, they are usually still important for the local people as toponyms in way descriptions and the like. Please render historic=city_gate (not necessarily with an icon, but maybe like place=locality?).
http://taginfo.openstreetmap.org/tags/historic=city_gate
The text was updated successfully, but these errors were encountered: