Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for man_made=tower #181

Closed
NonnEmilia opened this issue Sep 20, 2013 · 6 comments
Closed

Add rendering for man_made=tower #181

NonnEmilia opened this issue Sep 20, 2013 · 6 comments
Labels
amenity-points enhancement new features Requests to render new features
Milestone

Comments

@NonnEmilia
Copy link

Actually man_made=tower is not rendered, but if building=* tag is present yes.
Taginfo said that only 8% have also building=* cause, according to the wiki, building=* tag on man_made=tower is not needed.

Should man_made=tower be renderd as buildings?

@dieterdreist
Copy link

actually only a small amount of all towers are mapped as outline, so it is
not possible to render them the same way we render buildings. Also the tag
is used for very different kinds of towers, so I'd prefer to render
specific "tower:type"s and not all kinds of towers with an icon (especially
on lower zooms). Anyway, a tower is also a building so I don't want to
discourage adding a building tag to tower polygons neither.

Node
105 811
Way
12 829

@tyrasd
Copy link
Contributor

tyrasd commented Sep 20, 2013

Interestingly, man_made=mast is rendered with its own icon, although that tag is much less frequently used in comparison with man_made=tower:

@dieterdreist
Copy link

2013/9/20 Martin Raifer [email protected]

Interestingly, man_made=mast is rendered with its own icon, although that
tag is much less frequently used in comparison with man_made=tower:

yes, but it is more clear what that is, and they tend to be all landmarks,
what can't be said for all towers...

@jaakkoh
Copy link

jaakkoh commented Feb 14, 2014

@tyrasd / @dieterdreist : I haven't dug into what triggers the above rendering and e.g. Taginfo doesn't show usage combinations so I won't guess. But I do know that at least if there's a tower:type=communication in conjunction with man_made=mast then that icon is shown in OSM Mapnik (example: http://www.openstreetmap.org/node/2666366790).

I think this same rendering should happen when using man_made=tower (with tower:type=communication), which currently doesn't (http://www.openstreetmap.org/node/2489765793).

I opened a separate issue for (always) rendering tower:type=communication - #339 .

@matthijsmelissen
Copy link
Collaborator

@matthijsmelissen matthijsmelissen added this to the New features milestone Aug 18, 2014
@matthijsmelissen matthijsmelissen changed the title Rendering of man_made=tower Add rendering for of man_made=tower Sep 24, 2014
@matthijsmelissen matthijsmelissen changed the title Add rendering for of man_made=tower Add rendering for man_made=tower Sep 24, 2014
@matkoniecz
Copy link
Contributor

Towers that are also buildings should be tagged also with building tag (what will render them). Other towers are special, it is impossible to show all using one method and maybe some should not be rendered. Probably tower:type may be used (available in the database) - see #339.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amenity-points enhancement new features Requests to render new features
Projects
None yet
Development

No branches or pull requests

6 participants