-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Railway platforms with covered=yes should be rendered again #3421
Comments
Yes, it's because of covered=yes tag. See #3162 |
I don't see a reason not to render covered platforms. It might just mean that the platform has a roof over its full length. Not rendering underground platforms makes more sense, but covered=yes does not imply underground. |
1 similar comment
I don't see a reason not to render covered platforms. It might just mean that the platform has a roof over its full length. Not rendering underground platforms makes more sense, but covered=yes does not imply underground. |
There was a report on this before - what do you think about this reply? #3162 (comment) |
I was assuming exactly this and found it to be a problem too. |
That issue is about clearly defined underground platforms, tagged with location=underground. This platform does not have such a tag so it should not be treated as such. |
I would not go with trying to explain it in the framework of underground, as I said I was aware that this is another, but similar kind of problem (without assumption that it is underground). So please let's focus on the question whether covered should or should not be rendered (and why yes or why not). Tagging on this station is not clear to me - there's also https://www.openstreetmap.org/way/288846038, which looks that platform 2 is probably duplicated and some of them overlap. Please review this and fix if possible. |
I think if it is underground (and tagged as such), the reasoning to not render it is valid. If it is not underground, than it should not be treated as such. Or at least be rendered as something visible. BTW: 288846038 does not overlap. I do see a difference though, 288846045 is in a multiplolygon relation for a platform which is not covered, and as such will probably be rendered because of that. 288846041 is not. |
Quick investigation (exporting OSM file and replacing names with something like 2x, 2y etc): there are like 4 objects named "Perron 2", and the rendered name comes from https://www.openstreetmap.org/relation/7831438, because it has no Are you sure you need all 4 with the same name "Perron 2"? |
Many railway platforms are not rendered indeed, for instance https://www.openstreetmap.org/way/140249174 which holds the tag covered=yes. This is indeed different from location=underground and I think it should be rendered. This seems to be caused by this piece of code, line 688 in project.mml |
I think the tag An additional possibility should be to map the marquise as a building roof. |
I also wondered why https://www.openstreetmap.org/way/388148758 is not rendered and came across this issue. Notice a close highway=platform (a bus platform) is rendered fine even when covered=yes: https://www.openstreetmap.org/way/126362312 . |
I came across this railway platform that does not get rendered anymore: https://www.openstreetmap.org/way/288846041
An adjacent platform is getting rendered: https://www.openstreetmap.org/way/548528350
The only difference I see is covered=yes on the one that does not get rendered. I'm sure it was being rendered in earlier versions of the stylesheet.
The text was updated successfully, but these errors were encountered: