Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.21 release #3736

Closed
pnorman opened this issue Apr 4, 2019 · 13 comments
Closed

v4.21 release #3736

pnorman opened this issue Apr 4, 2019 · 13 comments

Comments

@pnorman
Copy link
Collaborator

pnorman commented Apr 4, 2019

I'd like to get out a v4.21 release for a branch point for schema changes, and to get the pointonsurface stuff out.

Are there any other ready to merge PRs that we should get in before release?

@imagico
Copy link
Collaborator

imagico commented Apr 6, 2019

I have merged a number of things that were ready a few days back so i think we would be fine for a release now.

@jeisenbe
Copy link
Collaborator

I'm fine with doing the release now. The PRs that are currently open can wait till the next month.

@pnorman
Copy link
Collaborator Author

pnorman commented Apr 12, 2019

If someone else can test and handle the release process that would be good. I'm busy with a move that includes my computer.

@pnorman
Copy link
Collaborator Author

pnorman commented Apr 17, 2019

Just noting that this is on my to-do list, and my development machine is still in its shipping box.

@pnorman
Copy link
Collaborator Author

pnorman commented May 2, 2019

Done, and created the schema_changes branch. As a reminder for maintainers, when tagging a new release it's your responsibility to merge it to this branch

If there are any long-running development branches check them out and merge the new release with git merge $NEW_RELEASE

@pnorman pnorman closed this as completed May 2, 2019
@jeisenbe
Copy link
Collaborator

jeisenbe commented May 2, 2019

I wish I had mentioned that #3759 should have been fixed before this release (All shop text labels are no longer being displayed after #3712). I've submitted #3760 with the fix.

It would also be nice to fix #3765 which is also caused by #3712 but it's not as noticeable.

@pnorman
Copy link
Collaborator Author

pnorman commented May 4, 2019

These sound like big enough bugs to release a v4.21.1

@kocio-pl
Copy link
Collaborator

kocio-pl commented May 5, 2019

Another big enough regression problem: #3765.

@kocio-pl
Copy link
Collaborator

Yet another regression bug: #3780.

@pnorman
Copy link
Collaborator Author

pnorman commented May 30, 2019

I've tagged v4.21.1 somewhat belatedly. Do we think there's enough stuff for v4.22.0 soon? If so I'll hold off the v4.21.1 announcement.

@jeisenbe
Copy link
Collaborator

It looks like no new bugs have been discovered in the past couple of months. Do we have enough for v4.22.0 or should v4.21.1 be released soon?

@pnorman
Copy link
Collaborator Author

pnorman commented Aug 21, 2019

I'd go for v4.22.0 after reviewing PRs

@jeisenbe
Copy link
Collaborator

Close in favor of v4.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants