Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line-color should be related to polygon-fill for most if not all polygon features #57

Closed
ian29 opened this issue Jun 10, 2013 · 11 comments

Comments

@ian29
Copy link
Contributor

ian29 commented Jun 10, 2013

This would simplify both the visual style and the code base considerably. Ideally we do this by establishing a convention like

polygon-fill: @some_color;
line-color: darken(@some_color, 10%)

although I imagine there will need to be considerable tweaking

@matthijsmelissen
Copy link
Collaborator

@floscher is this issue solved, or is there more that needs to be done?

@matthijsmelissen
Copy link
Collaborator

This has been resolved in the meanwhile.

@matthijsmelissen
Copy link
Collaborator

Why you think they are not related? They have the same hue, at least.

@matkoniecz
Copy link
Contributor

I think that these are related, that is why this ticket applies to them and is not fixed (I replied to "This has been resolved in the meanwhile.")

@matthijsmelissen
Copy link
Collaborator

I don't follow you. If color and fill are related, the issue is solved, isn't it?

@matkoniecz
Copy link
Contributor

I thought that replacing direct color definitions by darken(@color, something%) was part of this ticket ("Ideally we do this by").

I also think that it is a good idea, as it makes later changes of colours easier.

@matthijsmelissen
Copy link
Collaborator

Darken works on rgb, here basically the same has been done in Lch. I think Lch is preferable, even though Carto does not support it natively.

@matkoniecz
Copy link
Contributor

OK, so with this part rejected I also think that this is solved.

@HolgerJeromin
Copy link
Contributor

I think Lch is preferable, even though Carto does not support it natively.

which is btw issue:
mapbox/carto#354

@pnorman
Copy link
Collaborator

pnorman commented Oct 15, 2014

Yes - the basic problem with darken(@color, something%) is that it not only darkens, but also changes the perceptual hue and chroma. With the old colours, that's not too serious an issue because they were chosen sloppily enough, but when you're working out all the colours in a perceptual colour space, it makes sense to do them all there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants