Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for hotel areas #775

Closed
matthijsmelissen opened this issue Jul 28, 2014 · 13 comments
Closed

Add rendering for hotel areas #775

matthijsmelissen opened this issue Jul 28, 2014 · 13 comments

Comments

@matthijsmelissen
Copy link
Collaborator

The following issue has been moved over from trac:

http://www.openstreetmap.org/?lat=28.38634&lon=-81.50292&zoom=17&layers=M Here the hotels are not rendered as areas, while the landuse areas are. Perhaps a grayish pink (cross between residential and commercial) would be best.

@Rovastar
Copy link
Contributor

Do we need something for this?

I normally tag them with landuse = retail.

@HolgerJeromin
Copy link
Contributor

+1 for rendering the size like we do for schools. Both could include multiple buildings.
Hotels are not so large. So perhaps a blue (as the icon) outline without fill would be OK.

@pnorman
Copy link
Collaborator

pnorman commented Jul 29, 2014

We haven't added area renderings to POIs in general. I see some value in it, but not sure. I'm also skeptical if there's room in the colour space for a new colour.

@matthijsmelissen matthijsmelissen added this to the New features milestone Aug 18, 2014
@DaveF63
Copy link

DaveF63 commented Dec 19, 2014

Hi
+1 for rendering if mapped as areas (and the similar for pubs). There are many rural hotels with very large grounds that include, car parks, gardens, sport pitches, even shooting ranges & golf courses.
It doesn't need a specific separate colour; the human eye is quite good a distinguishing different shades. A fraction more pink than schools maybe?

I'm not convinced that hotels are 'retail' & don't map them as such. I'd class them as 'service' which in business terms is a separate sector.

@matkoniecz
Copy link
Contributor

I'm also skeptical if there's room in the colour space for a new colour.

I am pretty sure that additional color at high zoom is a bad idea.

Also - for small hotels there would not be any benefit, large complexes would be anyway tagged with already rendered landuse=commercial.

I recommend rejecting this proposal.

@polarbearing
Copy link
Contributor

Outline would be useful, also for other touristic features, see summary in #1624.

@kocio-pl
Copy link
Collaborator

I guess we're out of colors for areas (and we should probably also rethink some already used - for example: what the hospital and school have in common, which social facility like orphanage does not have?).

Borders are the only hope for now, however it'd be good to think beforehand about the system for colors/styles. We can combine them with some icons (hotel already has it's own) to have more precise information - border style and color would be for more general categories, so we wouldn't need too much of them.

@DaveF63
Copy link

DaveF63 commented Aug 27, 2015

There are plenty more hues. There was a website (can't find a link atm) that showed how slight changes in colour appearance were easily delectable by the human eye.

I am pretty sure that additional color at high zoom is a bad idea.

I'm unsure why it's a bad idea. Hospitals & schools etc are rendered. Why stop there? Why not add entities such as hotels & pubs? How will it harm the rendering?

@polarbearing
Copy link
Contributor

plenty more hues ... easily delectable by the human eye

While you might be able to see the difference between hue A and B when you contrast them, it is a different issue to recognise one when you don't see the other.

border style and color would be for more general categories

Yes. Accommodation-blue, tourism-brown, educational-social-medical-yellow.

@kocio-pl
Copy link
Collaborator

What about embassy area like this?

@polarbearing
Copy link
Contributor

Embassy would be another case for an outline. Question is whether it has currently the correct colour, would amenity-brown be a better fit for embassy than transportation-blue? Updated table in #1624.

@dieterdreist
Copy link

2015-08-31 13:49 GMT+02:00 polarbearing [email protected]:

Embassy would be another case for an outline. Question is whether it has
currently the correct colour, would amenity-brown be a better fit for
embassy than transportation-blue? Updated table in #1624
#1624.

maybe something in administrative boundary color?

@matkoniecz
Copy link
Contributor

I am pretty sure that additional color at high zoom is a bad idea.

I'm unsure why it's a bad idea. Hospitals & schools etc are rendered. Why stop there? Why not add entities such as hotels & pubs? How will it harm the rendering?

Because it is impossible to display everything. Even JOSM editing style is not displaying all tags. At this moment this style so many things that unifying display or even removing features results in greater improvement than adding more features.

There are plenty more hues. There was a website (can't find a link atm) that showed how slight changes in colour appearance were easily delectable by the human eye.

Map should be readable. Using various brown-yellow colours for hospitals, schools, hotels, pubs etc and expecting people to be able to recognize this features would not result in a readable map.

At this moment we should stop. Rendering all areas (hotels, embassies, police stations, biergartens, restaurants, etc etc) - by outline or area rendering is simply impossible (assuming that one want map that is prettier than JOSM editing style).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants