Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support case-insensitive hotkeys #249

Open
jowcy opened this issue Oct 24, 2019 · 3 comments
Open

Support case-insensitive hotkeys #249

jowcy opened this issue Oct 24, 2019 · 3 comments

Comments

@jowcy
Copy link

jowcy commented Oct 24, 2019

Is your feature request related to a problem? Please describe.
Hotkeys all seem to fail when CAPSLOCK is enabled. Unless you define both CAPS and lowercase versions of the hotkey.

Describe the solution you'd like
A simple configuration flag or boolean react property to specify if ignoreCase is true/false. By defaulting to false this could be done as a non-breaking change.

Describe alternatives you've considered
Duplicating the keyMap entry for each shortcut to provide ALLCAPS and lowercase options may seem like an obvious workaround - but this may have the side effect of listing the shortcuts twice in the Shortcut Viewer

@jowcy
Copy link
Author

jowcy commented Oct 25, 2019

I should clarify - there's obviously still a use for Shift + 'a' and 'a' to be defined as different shortcuts. So i don't want to conflate Shift + 'a' and 'A'

@jowcy jowcy closed this as completed Oct 25, 2019
@jowcy jowcy reopened this Oct 25, 2019
@greena13
Copy link
Owner

greena13 commented Jan 1, 2020

Thanks for posting your issue.

Unfortunately I do not have the time to actively work on this package, but I am seeking other active maintainers. If you are willing to create a pull request or help out, that would be an excellent way of moving this forward.

@PatrickDesign
Copy link
Collaborator

This is a duplicate of #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants