Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ensure a valid name for exports #489

Merged
merged 3 commits into from
Nov 15, 2020

Conversation

eintxaurtieta
Copy link
Contributor

Summary

The PR is motivated by this issue: #481

Test plan

The code is quite simple, if the name starts with a number and/or has a hyphen it modifies it, otherwise, it returns the original, I have added the tests and everything seems to work perfectly, I hope it is helpful! 😀

@vercel
Copy link

vercel bot commented Aug 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gregberge/svgr/8251ot2w1
✅ Preview: https://svgr-git-fork-endikai-svgr-kebab-case.gregberge.vercel.app

@eintxaurtieta
Copy link
Contributor Author

Ping @gregberge

@gregberge gregberge merged commit 0eb8085 into gregberge:master Nov 15, 2020
@gregberge
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants