Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance degradation since LUA pop #101

Closed
ofirnk opened this issue Mar 10, 2016 · 1 comment
Closed

Performance degradation since LUA pop #101

ofirnk opened this issue Mar 10, 2016 · 1 comment
Assignees

Comments

@ofirnk
Copy link
Contributor

ofirnk commented Mar 10, 2016

Hey,

Since version 2.1.1 we're seeing a major performance hit on large (~150K) delayed queue.
After some investigation we've spotted a redis API change:

While version 2.1.0 used

final Set<Tuple> payloadSet = this.jedis.zrangeByScoreWithScores(key, -1, now, 0, 1);

https://github.com/gresrun/jesque/compare/jesque-2.1.0...jesque-2.1.1?expand=1#diff-b8c8d894abaf0c2984a9c5235a7a11d9L452

On the new (and awesome!) lua script the LIMIT is missing:

next(redis.call('ZRANGEBYSCORE', queueKey, '-inf', now, 'WITHSCORES')

https://github.com/gresrun/jesque/compare/jesque-2.1.0...jesque-2.1.1?expand=1#diff-e588be0a4ba44bf62e8390bb5f7914afR14

@ofirnk
Copy link
Contributor Author

ofirnk commented Mar 10, 2016

So it looks the only change that is needed is this:
redis.call('ZRANGEBYSCORE', queueKey, '-inf', now, 'WITHSCORES', 'LIMIT' , '0' , '1')

(added the last 3 parameters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants