From 82df8466520f786d9c217e204be43123852a1b0b Mon Sep 17 00:00:00 2001 From: Francesc Verdugo Date: Thu, 9 Jul 2020 14:31:17 +0200 Subject: [PATCH 1/2] Changing the meanin of inward/outward in SkeletonCellBasis Now, they return ReducedSkeletonCellBasis --- src/FESpaces/CellBases.jl | 8 ++++---- test/FESpacesTests/CellBasesTests.jl | 11 +++++++++-- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/src/FESpaces/CellBases.jl b/src/FESpaces/CellBases.jl index 7bdf2937f..c9e61bcc3 100644 --- a/src/FESpaces/CellBases.jl +++ b/src/FESpaces/CellBases.jl @@ -376,13 +376,13 @@ struct SkeletonCellBasis{T} <: GridapType right::CellBasis end -function Base.getproperty(x::SkeletonCellBasis, sym::Symbol) +function Base.getproperty(a::SkeletonCellBasis, sym::Symbol) if sym == :inward - x.left + ReducedSkeletonCellBasis(a.trial_style,1*a.left,0*a.right) elseif sym == :outward - x.right + ReducedSkeletonCellBasis(a.trial_style,0*a.left,1*a.right) else - getfield(x, sym) + getfield(a, sym) end end diff --git a/test/FESpacesTests/CellBasesTests.jl b/test/FESpacesTests/CellBasesTests.jl index 580305622..037af5fd5 100644 --- a/test/FESpacesTests/CellBasesTests.jl +++ b/test/FESpacesTests/CellBasesTests.jl @@ -165,8 +165,15 @@ sq = get_coordinates(squad) sv = restrict(v,strian) @test isa(sv,SkeletonCellBasis) @test is_test(sv) -@test sv.left === sv.inward -@test sv.right === sv.outward +_sv = sv.inward +@test isa(_sv,ReducedSkeletonCellBasis) +@test is_test(_sv) +@test evaluate(sv.inward.left,sq) == evaluate(sv.left,sq) +@test evaluate(sv.outward.right,sq) == evaluate(sv.right,sq) + +_sv = sv.outward +@test isa(_sv,ReducedSkeletonCellBasis) +@test is_test(_sv) _sv = jump(2*∇(sv)) @test isa(_sv,ReducedSkeletonCellBasis) From 90a94c153171d82002d167da5f3957a94a228c86 Mon Sep 17 00:00:00 2001 From: Francesc Verdugo Date: Thu, 9 Jul 2020 14:39:06 +0200 Subject: [PATCH 2/2] Opening version 0.13 --- NEWS.md | 7 +++++-- Project.toml | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/NEWS.md b/NEWS.md index 1b9ac6c43..eda75eec3 100644 --- a/NEWS.md +++ b/NEWS.md @@ -4,10 +4,13 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). -## Unreleased +## [0.13.0] - Unreleased + +### Changed + - The meaning of `inward/outward` has slightly changed for `SkeletonCellBasis` objects. Now, by accessing to these properties a `ReducedSkeletonCellBasis` is returned, which allows to use the result in a more flexible way (in particular, the result can be used in a similar way than the result of `jump` or `mean`).Since PR [#317](https://github.com/gridap/Gridap.jl/pull/317). ### Fixed - - Replaced += by add_entry!. Since PR [#316](https://github.com/gridap/Gridap.jl/pull/316). + - Replaced `+=` by `add_entry!`. Since PR [#316](https://github.com/gridap/Gridap.jl/pull/316). ## [0.12.0] - 2020-07-07 diff --git a/Project.toml b/Project.toml index 319e8c87e..65c7f4f46 100644 --- a/Project.toml +++ b/Project.toml @@ -1,7 +1,7 @@ name = "Gridap" uuid = "56d4f2e9-7ea1-5844-9cf6-b9c51ca7ce8e" authors = ["Santiago Badia ", "Francesc Verdugo "] -version = "0.12.0" +version = "0.13.0" [deps] AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"