Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing work from PR #249? #313

Closed
amartinhuertas opened this issue Jul 6, 2020 · 3 comments
Closed

Missing work from PR #249? #313

amartinhuertas opened this issue Jul 6, 2020 · 3 comments
Assignees
@amartinhuertas

Comments

@amartinhuertas
Copy link
Member

Hi @fverdugo,

I have the impression that two LOCs within SparseMatrixAssemblers.jl should have been rewritten as well after the incorporation of AlgebraInterfaces.jl in PR #249. In particular, shouldn't these LOCs:

call add_entry!(...) , as, e.g.,

Gridap.jl/src/FESpaces/SparseMatrixAssemblers.jl

Line 64 in db92103

add_entry!(vec,vals[i],_gid)
?

If you agree, and confirm, I will submit the PR ASAP to fix this.

@amartinhuertas
@amartinhuertas amartinhuertas self-assigned this Jul 6, 2020
@amartinhuertas
Copy link
Member Author

Hi @fverdugo ... any comments/remarks on this issue?

@fverdugo
Copy link
Member

fverdugo commented Jul 9, 2020

Yes you can change this if you wish!

@amartinhuertas amartinhuertas mentioned this issue Jul 9, 2020
Merged
@fverdugo
Copy link
Member

fverdugo commented Jul 9, 2020

Closed via PR #316

@fverdugo fverdugo closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amartinhuertas amartinhuertas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amartinhuertas @fverdugo