From 462b3753092282f4b268d92e8080d327fb749589 Mon Sep 17 00:00:00 2001 From: amartin Date: Fri, 11 Sep 2020 16:35:01 +1000 Subject: [PATCH 1/4] Added FESpaceWithLastDofRemoved alias for backward compatibility --- src/FESpaces/FESpaces.jl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/FESpaces/FESpaces.jl b/src/FESpaces/FESpaces.jl index ae8d6fa6b..7ac0dd655 100644 --- a/src/FESpaces/FESpaces.jl +++ b/src/FESpaces/FESpaces.jl @@ -204,7 +204,9 @@ export collect_cell_jacobian export collect_cell_jacobian_and_residual export collect_cell_residual +const FESpaceWithLastDofRemoved = FESpaceWithConstantFixed export FESpaceWithConstantFixed +export FESpaceWithLastDofRemoved export ZeroMeanFESpace export CLagrangianFESpace From ff129f5594d3fcf76965076c84b878c46d349a34 Mon Sep 17 00:00:00 2001 From: amartin Date: Sat, 12 Sep 2020 16:53:50 +1000 Subject: [PATCH 2/4] Added necessary lines of code to keep the old FESpaceWithDofRemoved alive for backwards compatibility --- NEWS.md | 7 +++++-- src/FESpaces/FESpaces.jl | 1 - src/FESpaces/FESpacesWithConstantFixed.jl | 3 +++ 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/NEWS.md b/NEWS.md index 1f74b4593..82f1ce3d3 100644 --- a/NEWS.md +++ b/NEWS.md @@ -4,10 +4,13 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). -## Unreleased +## [0.14.1] ### Added - - Added VectorWithEntryInserted and VectorWithEntryRemoved. Since PR [#401](https://github.com/gridap/Gridap.jl/pull/401/) + - Added VectorWithEntryInserted and VectorWithEntryRemoved. Since PR [#401](https://github.com/gridap/Gridap.jl/pull/401/). + +### Deprecated + - The name FESpaceWithLastDofRemoved has been deprecated in favor of its generalization FESpaceWithConstantFixed. Since PR [#396](https://github.com/gridap/Gridap.jl/pull/396). ## [0.14.0] - 2020-08-27 diff --git a/src/FESpaces/FESpaces.jl b/src/FESpaces/FESpaces.jl index 7ac0dd655..464ecac5b 100644 --- a/src/FESpaces/FESpaces.jl +++ b/src/FESpaces/FESpaces.jl @@ -204,7 +204,6 @@ export collect_cell_jacobian export collect_cell_jacobian_and_residual export collect_cell_residual -const FESpaceWithLastDofRemoved = FESpaceWithConstantFixed export FESpaceWithConstantFixed export FESpaceWithLastDofRemoved diff --git a/src/FESpaces/FESpacesWithConstantFixed.jl b/src/FESpaces/FESpacesWithConstantFixed.jl index eacaabcd0..e298b9805 100644 --- a/src/FESpaces/FESpacesWithConstantFixed.jl +++ b/src/FESpaces/FESpacesWithConstantFixed.jl @@ -30,6 +30,9 @@ struct FESpaceWithConstantFixed{CS,CA<:ConstantApproach} <: SingleFieldFESpace end end +const FESpaceWithLastDofRemoved{CS} = FESpaceWithConstantFixed{CS,FixConstant} +@deprecate FESpaceWithLastDofRemoved(space::SingleFieldFESpace) = FESpaceWithConstantFixed(space,true) + # Genuine functions function num_free_dofs(f::FESpaceWithConstantFixed{CS,FixConstant}) where {CS} num_free_dofs(f.space)-1 From 70efeb4d6b3bda365e46e720deed12d4f20f914d Mon Sep 17 00:00:00 2001 From: amartin Date: Sat, 12 Sep 2020 17:12:53 +1000 Subject: [PATCH 3/4] Fixed syntax error from ff129f5594d3fcf76965076c84b878c46d349a34 --- src/FESpaces/FESpacesWithConstantFixed.jl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/FESpaces/FESpacesWithConstantFixed.jl b/src/FESpaces/FESpacesWithConstantFixed.jl index e298b9805..cf0c0d779 100644 --- a/src/FESpaces/FESpacesWithConstantFixed.jl +++ b/src/FESpaces/FESpacesWithConstantFixed.jl @@ -30,8 +30,12 @@ struct FESpaceWithConstantFixed{CS,CA<:ConstantApproach} <: SingleFieldFESpace end end + const FESpaceWithLastDofRemoved{CS} = FESpaceWithConstantFixed{CS,FixConstant} -@deprecate FESpaceWithLastDofRemoved(space::SingleFieldFESpace) = FESpaceWithConstantFixed(space,true) + +@deprecate(FESpaceWithLastDofRemoved(space::SingleFieldFESpace), + FESpaceWithConstantFixed(space,true)) + # Genuine functions function num_free_dofs(f::FESpaceWithConstantFixed{CS,FixConstant}) where {CS} From bcaead3c6fe08f27756ba92e5a0128019767ff5f Mon Sep 17 00:00:00 2001 From: "Alberto F. Martin" <38347633+amartinhuertas@users.noreply.github.com> Date: Sat, 12 Sep 2020 17:21:02 +1000 Subject: [PATCH 4/4] Update NEWS.md --- NEWS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index 82f1ce3d3..236857e8e 100644 --- a/NEWS.md +++ b/NEWS.md @@ -10,7 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Added VectorWithEntryInserted and VectorWithEntryRemoved. Since PR [#401](https://github.com/gridap/Gridap.jl/pull/401/). ### Deprecated - - The name FESpaceWithLastDofRemoved has been deprecated in favor of its generalization FESpaceWithConstantFixed. Since PR [#396](https://github.com/gridap/Gridap.jl/pull/396). + - The name FESpaceWithLastDofRemoved has been deprecated in favor of its generalization FESpaceWithConstantFixed. Since PR [#396](https://github.com/gridap/Gridap.jl/pull/396) and PR [#404](https://github.com/gridap/Gridap.jl/pull/404). ## [0.14.0] - 2020-08-27