-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMG solver pending tasks #17
Comments
I will not assign myself any task right now since I will be leaving on vacation for a couple weeks. However feel free to leave me any work you want. I am doing the P-MultiGrid solver as a |
I'm working till next Wednesday and then leaving for a couple of weeks, I will try to do the second before that. |
Everything works out-of-the-box when using more than 1 coarser task. I ran MeshHierarchiesTests.jl RedistributeToolsTests.jl and GMGLinearSolversPoissonTests.jl with 2 coarser tasks successfully in my desktop (only changes in the insignificant digits of the final residual). Is there any other test to run @amartinhuertas ? |
Regarding the third point only a minor fix is needed, just the line
so only tasks actually assigned to level 1 enter into the computation (otherwise the definition of the FESpace breaks). The generation at Then GMGLinearSolversPoissonTests.jl runs successfully with 6 MPI tasks and the following changes:
|
Fantastic, thanks!. I guess that in the coarser level
No, that I am aware of. Perhaps we may modify in the repo some of these tests such that they are run with 2 MPI tasks at the last level? |
Ok, no worries. Enjoy your holidays! I have already assigned you the first task, I may solve it before you come back. In such a case I will check the box. |
Great, thanks! Can you do PR into the |
FYI ... I solved task
Please be aware of the following subtlety 2aadaa6#diff-b478369422498837742b114d4c734f83605f7cd02d55d72bdd6db034ea6f9e26R249 i.e., preconditioner versus linear solver modes of |
We have completed all the tasks in this issue. Closing ... |
@principejavier @JordiManyer @santiagobadia, FYI, ... filling a set of pending (short-term) tasks related to geometric multigrid as I go.
Please feel free to add tasks if you see something which might be pending/good to have/limitation to fix, etc.
You may contribute to some of the current tasks if you are interested. If this is the case, please add your name to the end of the task. I have already added my name to one of these tasks.
GMG!
is currently a function. With composability in mind, we should design a type, say,GMGLinearSolver
which extends/implements Gridap'sLinearSolver
interface. @amartinhuertas [2aadaa6]GMG!
does not work properly whenever there is a single level in the hierarchy. (convergence gets stuck). Solved in 687b8a7num_parts_x_level=[2,2,2,1]
. @principejavier [Minor fixes into generate mesh hierarchy #19]change_domain_fine_to_coarse
function. Click here for more details. This strategy results in the fine-grid FE function being integrated over the coarse-grid using the quadrature rule of the latter. In other words, we end up using a standard Gauss quadrature to integrate a piece-wise polynomial function with reduced regularity on the interface of the children cells. We can improve this by decomposing the integral over the coarse-grid cells as a sum of integrals over the children cells using the quadratures of the latter cells. To this end, we need to change the domain of the coarse test function to the fine-grid, as we do with the trial function in thechange_domain_coarse_to_fine
function.PatchBasedLinearSolver
. See here for more details. @amartinhuertasOctreeDistributedDiscreteModel
should implement the interface ofDistributedDiscreteModel
. Quality of life methods likeget_cells
, ...The text was updated successfully, but these errors were encountered: