Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old interfaces and migrate CSS #92

Closed
1 of 4 tasks
iangreenleaf opened this issue Oct 26, 2015 · 4 comments
Closed
1 of 4 tasks

Drop old interfaces and migrate CSS #92

iangreenleaf opened this issue Oct 26, 2015 · 4 comments
Milestone

Comments

@iangreenleaf
Copy link
Member

A lot of work has already occurred on this, but it doesn't have a ticket open yet. In short, we plan to drop support for the older interfaces and use something resembling Postmodern for all users. @baldwint put in a Herculean effort porting most or all of the standard stylesheet options to work with this new interface, so we can migrate everyone who's using those. Then the only drawback is that anyone using a custom stylesheet that depends on the old interfaces will have it break, which hopefully we can minimize.

@iangreenleaf
Copy link
Member Author

@baldwint, could you clarify for me how far the CS porting is? Blue, Jolly and Parchment are not yet ported, is that correct? And is all of your work found in https://github.com/baldwint/planscss ?

@baldwint
Copy link

The CSS porting is complete for every built-in stylesheet. Yes, all my work is in the repo you linked, but not in branch master. The new sheets are in the css branch (I used master exclusively to code up a preview tool in PhantomJS).

This work was committed to PHP Plans in a single giant patch on March 15. It was partially reverted a month later because someone really hated having the pre-2009 plans logos back. I think it must have been a younger person who didn't know that those were original, vintage logos, painstakingly recovered from the dank depths of the SVN repo. Anyway if you share that person's opinion you should pull from the nologos branch instead (check the network graph).

I don't have much time to work on plans these days but I hope this helps you guys.

@iangreenleaf
Copy link
Member Author

@baldwint thank you, that was exactly the information I needed. I'll pull in all your latest sheets, and uhhhhh we'll see about those vintage logos.

@iangreenleaf
Copy link
Member Author

I'm going to break out further work on this into tickets under a new milestone: #139 and #140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants