-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inline child re-ordering drag and drop #5
Comments
It don't work for inner elements, just grids, I tried to drag a visual element or a name from right list, but no success. Grids works just vertical or is confusing on horizontal dragging. |
Thanks for reporting. I’ll take a look to tomorrow, when I have access to a laptop again 🙂 |
Can you provide more context for the problem you are seeing? For example, design data, which elements you are attempting to drag and drop onto, and which browser you are using? |
Sorry for late response. Now, I was testing the drag and drop, and works great, my problem is about Visual Feedback. CONTEXT OF MY COMMENTI work coding with react, but lately I was working with non coding designers. I wish to introduce grommet-designer to them, but I think this designer must have some sort of basic features for them to pickup, and drag and drop is one of them. I know putting too much features to the designer will make more harm than good, but a good dragging will be a good selling point to the designer. PROBLEMUsually on this kind of designers, when you move an element, you "see" an space where it will go, but in grommet designer now there is a box inside parent. So is like you know that element will be inside that parent, but not exactly where. SUGGESTIONAdding an empty-with-blank-background-box signaling where exactly the element will reallocate would be the best approach. Another option is actually move the element with some transparency, but I know it will add almost unnecessary process power, so I think some sort of placeholder will do the trick. OTHER IDEA:"Reserve" the space with blank space and placeholder text. |
Thanks for the details. Agreed. I've been working some designers to improve it for their workflow. I like your suggestion. I'll take a stab at it. |
Allow dragging and dropping in the main content to re-order children.
The text was updated successfully, but these errors were encountered: