Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline child re-ordering drag and drop #5

Open
ericsoderberghp opened this issue Jun 4, 2019 · 5 comments
Open

inline child re-ordering drag and drop #5

ericsoderberghp opened this issue Jun 4, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@ericsoderberghp
Copy link
Contributor

Allow dragging and dropping in the main content to re-order children.

@ericsoderberghp ericsoderberghp self-assigned this Jun 6, 2019
@ericsoderberghp ericsoderberghp added the enhancement New feature or request label Jun 6, 2019
@Israel-Laguan
Copy link

Israel-Laguan commented Jun 10, 2019

It don't work for inner elements, just grids, I tried to drag a visual element or a name from right list, but no success. Grids works just vertical or is confusing on horizontal dragging.

@ericsoderberghp
Copy link
Contributor Author

Thanks for reporting. I’ll take a look to tomorrow, when I have access to a laptop again 🙂

@ericsoderberghp
Copy link
Contributor Author

It don't work for inner elements, just grids, I tried to drag a visual element or a name from right list, but no success. Grids works just vertical or is confusing on horizontal dragging.

Can you provide more context for the problem you are seeing? For example, design data, which elements you are attempting to drag and drop onto, and which browser you are using?

@ericsoderberghp ericsoderberghp added question Further information is requested and removed enhancement New feature or request labels Jun 11, 2019
@Israel-Laguan
Copy link

It don't work for inner elements, just grids, I tried to drag a visual element or a name from right list, but no success. Grids works just vertical or is confusing on horizontal dragging.

Can you provide more context for the problem you are seeing? For example, design data, which elements you are attempting to drag and drop onto, and which browser you are using?

Sorry for late response.

Now, I was testing the drag and drop, and works great, my problem is about Visual Feedback.

CONTEXT OF MY COMMENT

I work coding with react, but lately I was working with non coding designers. I wish to introduce grommet-designer to them, but I think this designer must have some sort of basic features for them to pickup, and drag and drop is one of them. I know putting too much features to the designer will make more harm than good, but a good dragging will be a good selling point to the designer.

PROBLEM

Usually on this kind of designers, when you move an element, you "see" an space where it will go, but in grommet designer now there is a box inside parent. So is like you know that element will be inside that parent, but not exactly where.

SUGGESTION

Adding an empty-with-blank-background-box signaling where exactly the element will reallocate would be the best approach. Another option is actually move the element with some transparency, but I know it will add almost unnecessary process power, so I think some sort of placeholder will do the trick.

OTHER IDEA:

image

"Reserve" the space with blank space and placeholder text.

@ericsoderberghp
Copy link
Contributor Author

Thanks for the details. Agreed. I've been working some designers to improve it for their workflow. I like your suggestion. I'll take a stab at it.

@ericsoderberghp ericsoderberghp added enhancement New feature or request and removed question Further information is requested labels Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants