Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoverindicator styling for a box with a background image is jarring #31

Open
ecircenis opened this issue Apr 1, 2020 · 1 comment
Open

Comments

@ecircenis
Copy link

When a box has a background image and has a hoverindicator set, hovering over the box causes the box background to go grey, completely losing the background image context. Ideally the hover indicator on a box would either outline the box or change the background opacity or lighten/darken the background.

Example of a box (dark mode)
image

Same box being hovered (dark mode)
image

This is just as jarring in light mode.

@ecircenis
Copy link
Author

Same box being hovered in light mode. In this case, the button ends up having contrast issues. (because the background image is dark, the "dark" attribute is set to true. But the hover effect doesn't honor this dark setting and changes the background to light, causing accessibility issues.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant