Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change before_filter to before_action #169

Open
Qqwy opened this issue May 8, 2017 · 2 comments
Open

Change before_filter to before_action #169

Qqwy opened this issue May 8, 2017 · 2 comments

Comments

@Qqwy
Copy link

Qqwy commented May 8, 2017

When following the instructions in the readme, Rails 5.0 will show a deprecation warning that before_filter is deprecated, and that before_action should be used instead.

So I think that

# app/controllers/application_controller.rb
class ApplicationController < ...
  before_filter :set_gettext_locale

should be changed to

# app/controllers/application_controller.rb
class ApplicationController < ...
  before_action :set_gettext_locale
@grosser
Copy link
Owner

grosser commented May 8, 2017

yes! please make a PR!

@neohunter
Copy link
Contributor

Created PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants