-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculation of parallel_tests chunks does not take into account CLI submitted args #829
Comments
@luke-hill Do you have an example? Having one would help determine where in the stack the problem is. |
this is tricky because parallel_tests tries to avoid going too deep into the test-framework |
Every single feature inside features/advice has scenarios. Every single feature inside business rules has 0 scenarios and/or is tagged as |
Oh, this is a feature request? Sorry, my mind was in Bug Mode when I was reading the initial issue. As far as the "it's difficult but it could be done" angle goes, I can say that the Regarding the necessity of implementing something like this, it strikes me as a bit self inflicted if a user is both requesting a profile that will filter out certain features/tests while also requesting that those things are run. It might end up being a lot of work to implement this kind of thing just to squeeze a bit more performance out of a large test suite when the problem could be avoided by having better test organization/planning by the user if they really need every last drop of speed. |
I'm not requesting they are run. So normally (Without parallelism), we say run all features except these features. When we run in parallel, we don't get the chance to say exclude these features at any point. So at the point the space delimited list of features comes in, we don't have any chance to filter. Maybe if we had a manual way to filter that would help. i.e. if we could run parallel cucumber only on one subdirectory/subdirectories @grosser ? |
you can run |
I'll try this, maybe this is functionality that isn't needed. |
When running a CLI command where you pass in a profile, i.e. lets say the profile omits all tests that have the
@foo
tag.When you get to the calculation phase for how to "chunk" the tests up, those features with the tag are included in the calculation. They won't be executed, but it means the chunking can be very uneven.
This may need fixing downstream @enkessler
The text was updated successfully, but these errors were encountered: