Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support map type in query string #316

Closed
tamalsaha opened this issue Feb 27, 2017 · 3 comments
Closed

Support map type in query string #316

tamalsaha opened this issue Feb 27, 2017 · 3 comments

Comments

@tamalsaha
Copy link
Collaborator

tamalsaha commented Feb 27, 2017

Is it possible to support map[string]string in the query parameters?

@sagikazarmark
Copy link

Something like ?filters[key]=value would be nice

@tmc
Copy link
Collaborator

tmc commented Mar 16, 2017

I think this would be a nice addition -- the http.proto documentation doesn't describe map field population from query arguments so my only concern here would be a divergence from how any equivalent google service would behave (e.g. cloud endpoints).

@tamalsaha
Copy link
Collaborator Author

@tmc, that might be just an artifacts of the fact that original protobuf did not have map types and http.proto was defined before proto 3 (my guess).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants