-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept X-Method-Override header when doing POST -> GET path length fallback #3297
Comments
Hi, this seems reasonable, but could you expand a bit on the problem? What browsers? Why? Is there a spec somewhere for this behavior? Is it a bug in the browser? |
Hi, I don't really know the details and I can't find documentation confirming it but when I set the That's all I've got |
Hm, that sounds odd, could you share the code? If we're going to add this sort of workaround I just want to make sure it's appropriate. What's the behavior in Firefox? Safari? Edge? |
I've tried with Chrome, Safari and Postman and they all rename the
|
I tested this in Firefox and Chrome and just judging by the network tab it didn't exhibit the header rewrite. Could you maybe share a JS snippet that reproduces this? |
Yea, in the network tab we see the header as is but we receive it renamed on the server side. I am quite confused as well and I can't find any documentation on this matter 🤷
We use https://openapi-generator.tech/docs/generators/typescript-rxjs to generate a client from openapi specs But even so, |
I'm not trying to be difficult here, just making sure we're making the right decision for the project, I'm sure you can understand 😁. Could you share some references for the use of the |
I know this is an old one but I found a bug around the same code: #3688 |
🚀 Feature
(A clear and concise description of what the feature is.)
Some browsers rename the
X-HTTP-Override-Method
header toX-Override-Method
which causes the POST -> GET path length fallback to not kick in.Feature proposal:
X-Override-Method
andX-HTTP-Override-Method
headersPotential solution:
X-Override-Method
header and then tryX-HTTP-Override-Method
if not setThe text was updated successfully, but these errors were encountered: