Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider a temporary flag to control output location of "context" package. #349

Closed
tmc opened this issue Apr 4, 2017 · 4 comments
Closed
Labels

Comments

@tmc
Copy link
Collaborator

tmc commented Apr 4, 2017

Refs #343

@simonpasquier
Copy link
Contributor

Trying to get away from golang.org/x/net/context for my own projects, I wonder if it wouldn't be possible for grpc-gateway to switch using context from the standard library now. Specifically wouldn't it be ok to change this line to "context"?

@johanbrandhorst
Copy link
Collaborator

I'd say yes. We should have the same support guarantees as the standard library which means current release - 2, which still leave us at 1.9. Context was added in 1.7. Would you be interested in contributing a fix for this?

@simonpasquier
Copy link
Contributor

@johanbrandhorst sure, I'll send something soon...

@stale
Copy link

stale bot commented Sep 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 9, 2019
@stale stale bot closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants