Not able to pass allow_delete_body to protoc-gen-grpc-gateway.

[uynap]

I looked through the documents and searched the google. I tried to pass "allow_delete_body" to protoc-gen-grpc-gateway but failed.

It ends up with the question: how to pass the "allow_delete_body" to protoc-gen-grpc-gateway when issuing "protoc"?

Here's my currently protoc command:

protoc -I${GOPATH}/src/google.golang.org/genproto/googleapis \
      -I${GOPATH}/src/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis \
      -I${GOPATH}/src/github.com/golang/protobuf/ptypes \
      -I${GOPATH}/src \
      -I. \
      --plugin=protoc-gen-grpc-gateway=${GOPATH}/bin/protoc-gen-grpc-gateway --allow_delete_body=true \
      --go_out=plugins=grpc:. \
      --grpc-gateway_out=logtostderr=true:. \
      ${SOURCEDIR}/proto/route/*.proto

I got error message:
Unknown flag: --allow_delete_body

[tamalsaha]

I am guessing you are using old version of plugin. This flag was added recently. https://github.com/grpc-ecosystem/grpc-gateway/commits/master

[uynap]

@tamalsaha I think I'm using the latest one.

$ ~/go/bin/protoc-gen-grpc-gateway --help
Usage of /Users/py/go/bin/protoc-gen-grpc-gateway:
  -allow_delete_body
    	unless set, HTTP DELETE methods may not have a body

I saw it's a recently added feature.

[uynap]

I also tried to run

~/go/bin/protoc-gen-grpc-gateway --allow_delete_body

without any issue.

That's why I guess the problem is "the way" I passed it to "protoc" is wrong.

[achew22]

@uynap last time I played the protoc flag game was > 1 year ago so I'm working from foggy memories. I do think the problem is the way you're passing your flag into protoc. Could you try:

protoc -I${GOPATH}/src/google.golang.org/genproto/googleapis \
      -I${GOPATH}/src/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis \
      -I${GOPATH}/src/github.com/golang/protobuf/ptypes \
      -I${GOPATH}/src \
      -I. \
      --plugin=protoc-gen-grpc-gateway=${GOPATH}/bin/protoc-gen-grpc-gateway --allow_delete_body=true \
      --go_out=plugins=grpc:. \
      --grpc-gateway_out=logtostderr=true:allow_delete_body=true:. \
      ${SOURCEDIR}/proto/route/*.proto

Notice that I added it to the --grpc-gateway_out flag. I think the syntax, again this is an old memory, is argument1=value:argument2=value:path_to_generate_your_files_in.

[tamalsaha]

I believe the flags are comma separated. Here is a snippet from our build scripts:

  protoc -I /usr/local/include -I . \
         -I ${GOPATH}/src/github.com \
         -I ${GOPATH}/src/github.com/googleapis/googleapis/ \
         -I ${GOPATH}/src/github.com/grpc-ecosystem/grpc-gateway/third_party/appscodeapis \
         --grpc-js-client_out=logtostderr=true,remove_prefix=/_appscode/api,${ALIAS}:. *.proto

[achew22]

@tamalsaha, thanks for following up. Given that his sample came from a real makefile instead of the back of my head I would like to revise my question. Can you try this out:

protoc -I${GOPATH}/src/google.golang.org/genproto/googleapis \
      -I${GOPATH}/src/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis \
      -I${GOPATH}/src/github.com/golang/protobuf/ptypes \
      -I${GOPATH}/src \
      -I. \
      --plugin=protoc-gen-grpc-gateway=${GOPATH}/bin/protoc-gen-grpc-gateway --allow_delete_body=true \
      --go_out=plugins=grpc:. \
      --grpc-gateway_out=logtostderr=true,allow_delete_body=true:. \
      ${SOURCEDIR}/proto/route/*.proto

[uynap]

@tamalsaha Thanks a lot! It's exactly what I'm looking for. It is "comma separated".
Do you know where I can find documents on how to write "protoc" arguments? I read a lot of gRPC and related documents, but never seen it before.

[tamalsaha]

@uynap , not sure where I found that. It has a been while. Usually bit of trial and error and head scratching gets the job done. :)