Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow compiling the gateway code to a different go package #463

Closed
MatthewDolan opened this issue Sep 20, 2017 · 1 comment
Closed

Allow compiling the gateway code to a different go package #463

MatthewDolan opened this issue Sep 20, 2017 · 1 comment

Comments

@MatthewDolan
Copy link
Contributor

Currently, the expectation is that the generated gateway code (.pb.gw.go) will live in the same package as the generated service code (.pb.go). There is no package import when referencing it.

Add an optional flag that allows package import so that gateway code can be put into another package and import what it needs from the proto code (it appears to only require public functions and types).

The motivation here is that if a project has a client it wants to distributed externally and also wants to use grpc gateway server side, it would be nice to not mandate that the client import grpc gateway.

@MatthewDolan
Copy link
Contributor Author

This has been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant