Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code still imports "golang.org/x/net/context" #533

Closed
muudyguy opened this issue Jan 26, 2018 · 1 comment
Closed

Source code still imports "golang.org/x/net/context" #533

muudyguy opened this issue Jan 26, 2018 · 1 comment

Comments

@muudyguy
Copy link

Hi there,

I am trying to set up grpc-gateway for our project in golang 1.9. As you know golang.org/x/net/context is no longer there in this version, however the source code that needs to be included for the imports in the proto file, still tries to import golang.org/x/net/context. I am not sure how to move forward to fix this issue, any ideas ? (Except go get golang.org/x/net/context)

@achew22
Copy link
Collaborator

achew22 commented Jan 26, 2018

That's probably the best way to go forward today. For now we maintain compatibility with the 2 latest versions of Go. Fortunately Go 1.10 is expected out in Feb which is pretty soon. When that's released we will migrate to the built in context package and this shouldn't be an issue any more.

Thanks so much for filing an issue! Without field reports we have no idea the things we need to focus on. I'm going to close this since we are already tracking this in #326 which I'm itching to close 😄.

@achew22 achew22 closed this as completed Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants