Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: support fast creation of server objects #1285

Closed
Banyc opened this issue May 7, 2021 · 1 comment
Closed

Request: support fast creation of server objects #1285

Banyc opened this issue May 7, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@Banyc
Copy link

Banyc commented May 7, 2021

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

grpc-dotnet does not have a fast creation of server objects (at least in the tutorials). I don't want to rely on the aspnet core infrastructure when it comes to a class library.

Describe the solution you'd like

A clear and concise description of what you want to happen.

Support something like the following:

Grpc.Core.Server rpcServer = new()
{
    Services = { RpcMapReduceService.BindService(controller) },
    Ports = { new ServerPort(_settings.IpAddress, _settings.Port, ServerCredentials.Insecure) }
};

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Currently no.

Additional context

Add any other context about the feature request here.

Due to the fact that Grpc.Core is about to be deprecated, I still want the neat API that Grpc.Core provides. Please consider this request because it is not appropriate for a class library to depend on aspnet core.

@Banyc Banyc added the enhancement New feature or request label May 7, 2021
@BrennanConroy
Copy link
Contributor

BrennanConroy commented May 7, 2021

it is not appropriate for a class library to depend on aspnet core

Sorry, but that isn't possible. Grpc.Core brings in a whole HTTP2 stack, whereas this Grpc library is built on top of the ASP.NET Core HTTP2 stack, it doesn't bundle its own.

Are you concerned that this library requires ASP.NET Core, or that you have to write ConfigureServices etc. when using Grpc server?

In 6.0 we have the minimal hosting feature coming in that makes your code smaller for startup dotnet/aspnetcore#32378

@JamesNK JamesNK closed this as completed May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants