Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilizing ClientInterceptor API #1898

Closed
aamitdb opened this issue Mar 5, 2018 · 1 comment
Closed

Stabilizing ClientInterceptor API #1898

aamitdb opened this issue Mar 5, 2018 · 1 comment

Comments

@aamitdb
Copy link

aamitdb commented Mar 5, 2018

The client interceptors APIs are marked as experimental on HEAD still

type UnaryClientInterceptor func(ctx context.Context, method string, req, reply interface{}, cc *ClientConn, invoker UnaryInvoker, opts ...CallOption) error
.

I'm not aware of any issue blocking them from being promoted to stable, although I see some requests tagged as "feature" e.g. #1805 about changing them.

Can the apis be promoted to stable or is there any place I can track the remaining work to be done on them?

Asked same q on mailing list and got directed to open an issue here.

@dfawley
Copy link
Member

dfawley commented Mar 8, 2018

@aamitdb We don't intend to make any changes to this API; however, we do intend to replace it eventually. When we do so, we will make sure we do at least one major release containing both the new and old APIs to provide an opportunity to migrate. The new API should be very similar, so isn't expected to take much effort to change. We would like to leave these marked as experimental until then.

Thanks!

@dfawley dfawley closed this as completed Mar 8, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants