diff --git a/balancer/weightedroundrobin/balancer.go b/balancer/weightedroundrobin/balancer.go index ed241124219e..ec7a8b1061ab 100644 --- a/balancer/weightedroundrobin/balancer.go +++ b/balancer/weightedroundrobin/balancer.go @@ -513,7 +513,7 @@ func (w *weightedSubConn) OnLoadReport(load *v3orcapb.OrcaLoadReport) { } w.lastUpdated = internal.TimeNow() - if w.nonEmptySince == (time.Time{}) { + if w.nonEmptySince.Equal(time.Time{}) { w.nonEmptySince = w.lastUpdated } } @@ -608,7 +608,7 @@ func (w *weightedSubConn) weight(now time.Time, weightExpirationPeriod, blackout // The SubConn has not received a load report (i.e. just turned READY with // no load report). - if w.lastUpdated == (time.Time{}) { + if w.lastUpdated.Equal(time.Time{}) { endpointWeightNotYetUsableMetric.Record(w.metricsRecorder, 1, w.target, w.locality) return 0 } @@ -625,7 +625,7 @@ func (w *weightedSubConn) weight(now time.Time, weightExpirationPeriod, blackout } // If we don't have at least blackoutPeriod worth of data, return 0. - if blackoutPeriod != 0 && (w.nonEmptySince == (time.Time{}) || now.Sub(w.nonEmptySince) < blackoutPeriod) { + if blackoutPeriod != 0 && (w.nonEmptySince.Equal(time.Time{}) || now.Sub(w.nonEmptySince) < blackoutPeriod) { if recordMetrics { endpointWeightNotYetUsableMetric.Record(w.metricsRecorder, 1, w.target, w.locality) } diff --git a/benchmark/latency/latency.go b/benchmark/latency/latency.go index 10fcb12c8d4e..4fae637673ee 100644 --- a/benchmark/latency/latency.go +++ b/benchmark/latency/latency.go @@ -63,13 +63,13 @@ type Network struct { } var ( - //Local simulates local network. + // Local simulates local network. Local = Network{0, 0, 0} - //LAN simulates local area network. + // LAN simulates local area network. LAN = Network{100 * 1024, 2 * time.Millisecond, 1500} - //WAN simulates wide area network. + // WAN simulates wide area network. WAN = Network{20 * 1024, 30 * time.Millisecond, 1500} - //Longhaul simulates bad network. + // Longhaul simulates bad network. Longhaul = Network{1000 * 1024, 200 * time.Millisecond, 9000} ) diff --git a/test/config_selector_test.go b/test/config_selector_test.go index 69782ef9ce0b..78518d4fb5b9 100644 --- a/test/config_selector_test.go +++ b/test/config_selector_test.go @@ -200,7 +200,7 @@ func (s) TestConfigSelector(t *testing.T) { } wantDeadline := tc.wantDeadline - if wantDeadline == (time.Time{}) { + if wantDeadline.Equal(time.Time{}) { wantDeadline = startTime.Add(tc.wantTimeout) } deadlineGot, _ := gotContext.Deadline()