gRPC code generator needs to handle reserved words in method names

[carl-mastrangelo]

When defining an RPC like:

service Foo {
  rpc Import(ImportRequest) returns (ImportResponse) {};
}

The method Import gets translated to a java keyword. When should adjust it by adding an underscore (prepended?) to allow it to compile.

[ejona86]

We should probably mimic protobuf (e.g., prepend if it prepends)

[zpencer]

Fields always have a "_" appended, which avoids the problem:

message False {
  Native import = 1;
  string mYsTr = 2;
}

private volatile java.lang.Object mYsTr_;
private io.grpc.channelz.v1.Native import_ = null;

I notice protobuf doesn't do anything special with java reserved keywords for message types, for example this generates invalid Java:

message native { // if this is capitalized it works
}

public  final class native extends
    com.google.protobuf.GeneratedMessageV3 implements
    // @@protoc_insertion_point(message_implements:grpc.channelz.native)
    nativeOrBuilder {

[ejona86]

And methods for fields have get or set prefix, so they're also fine. Messages virtually always start with an upper-case character and keywords are all lowercase. And enums are ALL_UPPER_CASE.