From f794b77934e6cb474dcc9018d5d8a12a698606b9 Mon Sep 17 00:00:00 2001 From: Michael Lumish Date: Wed, 13 Mar 2024 15:16:42 -0700 Subject: [PATCH] Address review comments --- examples/keepalive/README.md | 2 +- examples/keepalive/client.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/keepalive/README.md b/examples/keepalive/README.md index 8b859b1f0..0552d7285 100644 --- a/examples/keepalive/README.md +++ b/examples/keepalive/README.md @@ -12,5 +12,5 @@ node server.js ## Start the client ``` -GRPC_TRACE=transport,keepalive GRPC_VERBOSITY=DEBUG client.js +GRPC_TRACE=transport,keepalive GRPC_VERBOSITY=DEBUG node client.js ``` diff --git a/examples/keepalive/client.js b/examples/keepalive/client.js index 4da7756a8..b985c305f 100644 --- a/examples/keepalive/client.js +++ b/examples/keepalive/client.js @@ -33,7 +33,7 @@ const packageDefinition = protoLoader.loadSync( const echoProto = grpc.loadPackageDefinition(packageDefinition).grpc.examples.echo; const keepaliveOptions = { - // Ping the client every 10 seconds to ensure the connection is still active + // Ping the server every 10 seconds to ensure the connection is still active 'grpc.keepalive_time_ms': 10_000, // Wait 1 second for the ping ack before assuming the connection is dead 'grpc.keepalive_timeout_ms': 1_000,