-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental Typescript support #258
Conversation
So far, this PR demos how a typescript project can make use of the To run:
|
That looks right to me. One alternative to the |
} | ||
|
||
export interface GrpcWebClientBaseOptions { | ||
format?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we could add the suppressCorsPreflight
option to the GrpcWebClientBaseOptions
interface as well:
suppressCorsPreflight?: boolean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
Will try that. Thanks. |
Added a full Typescript example up to this point.
Uncomment either Line 25 or Line 26 to try between the two modes above:
|
Added 2 modes to the
|
2edebf9
to
1f45a03
Compare
Squashing commits. Got internal reviewed. Will merge this soon. |
- ts-protoc-gen clears out the callbacks anyways - Fixes grpc#257
For #255
I am going to try to expand on this. For my very initial understanding, this seems to work.
Feedback highly appreciated!
cc: @jonahbron