From 82c03abc9f499a8ff7c23b4bba4b533ce9f7826c Mon Sep 17 00:00:00 2001 From: weilip Date: Fri, 9 Nov 2018 16:29:20 +0800 Subject: [PATCH] Fix rpc method name clashes. When multiple services in the same proto file define same rpc --- javascript/net/grpc/web/grpc_generator.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/javascript/net/grpc/web/grpc_generator.cc b/javascript/net/grpc/web/grpc_generator.cc index 2d4e5889..e2e095d0 100644 --- a/javascript/net/grpc/web/grpc_generator.cc +++ b/javascript/net/grpc/web/grpc_generator.cc @@ -669,7 +669,7 @@ void PrintMethodInfo(Printer* printer, std::map vars) { " * !proto.$in$,\n" " * !proto.$out$>}\n" " */\n" - "const methodInfo_$method_name$ = " + "const methodInfo_$service_name$_$method_name$ = " "new grpc.web.AbstractClientBase.MethodInfo(\n"); printer->Indent(); printer->Print( @@ -723,7 +723,7 @@ void PrintUnaryCall(Printer* printer, std::map vars) { vars, "request,\n" "metadata,\n" - "methodInfo_$method_name$,\n" + "methodInfo_$service_name$_$method_name$,\n" "callback);\n"); printer->Outdent(); printer->Outdent(); @@ -793,7 +793,7 @@ void PrintServerStreamingCall(Printer* printer, std::map vars) { vars, "request,\n" "metadata,\n" - "methodInfo_$method_name$);\n"); + "methodInfo_$service_name$_$method_name$);\n"); printer->Outdent(); printer->Outdent(); printer->Outdent();