Fix response header value with colon #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitar
reviewed
Nov 10, 2018
| @@ -195,10 +195,10 @@ const GrpcWebClientReadableStream = function(genericTransportInterface) { | |||
| } | |||
| var responseHeaders = self.xhr_.getResponseHeaders(); | |||
There was a problem hiding this comment.
Why even use getResponseHeaders at all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #318.
Very strange, let's say we have this response header
grpc-message: Foo: Barsent back from gRPC backend service, and thru Envoy, from the browser console, the header value apparently was sent back properly.But, if I call
xhr.getResponseHeaders()to get the whole bag of response headers, one of the key:value pair wasgrpc-message: Foo.OTOH, if I call
xhr.getResponseHeader('grpc-message'), I getFoo: Barback properly.I couldn't find a bug from Chrome or Closure to report this strange behavior with
xhr.getResponseHeaders().Also OTOH, I cannot find any HTTP spec that said that http header value cannot have a colon in it. So apparently it's OK to have header value that has a colon in it.