-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix flakiness of 'bazel test' #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this works, thanks @Yannic!
I also tried the export OPENSSL_CONF=...
fix before and it didn't work. Didn't realize it has to be fixed on the bazel side. Our script seems to be no longer flaky.
Looks like we can remove .bazelrc
.
Yeah, Bazel is rather picky which parts of the environment are available in tests (If that's good or bad is left as an exercise to the reader). Thanks for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
The cause of the failures might have been fixed in bazelbuild/rules_closure#337.