Add fix for deadline of strings, NaN, Infinity and -Infinity

[CatEars]

This will change Infinity to Math.pow(2, 53) - 1 (Number.MAX_SAFE_INTEGER in ES6, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/MAX_SAFE_INTEGER). Anything that becomes NaN will be discarded (for example setting deadline to a string or NaN), -Infinity will also be discarded.

I don't know if it is best to let bad values for deadlines slip past silently or not...

[CatEars]

In response to issue #554

[stanley-cheung]

Sorry for the delaying in reviewing this.

Actually, in the gRPC protocol definition, if Timeout is omitted, it's assumed to be Infinite. So what we should be doing here is that, in L215, if "Infinity" is passed in, just don't set the "grpc-timeout" header. Does it make sense?

[CatEars]

Sorry for the delaying in reviewing this.

No problem, being an open source maintainer is tough work!

Actually, in the gRPC protocol definition, if Timeout is omitted, it's assumed to be Infinite. So what we should be doing here is that, in L215, if "Infinity" is passed in, just don't set the "grpc-timeout" header. Does it make sense?

I think then that defaulting to 0 is a good idea? I pushed up such a change in 5650699.

[stanley-cheung]

Thanks for the contributions and the updates.