Skip to content

Latest commit

 

History

History
97 lines (77 loc) · 4.1 KB

A64-lrs-custom-metrics.md

File metadata and controls

97 lines (77 loc) · 4.1 KB
Raw

A64: xDS LRS Custom Metrics Support

Abstract

This proposal describes how the gRPC xDS client will support custom metrics from the backends in load reports to the LRS server at the locality level.

Background

The initial xDS functionality in the gRPC client described in gRFC A27 includes the ability to report load to the control plane via LRS. However, those load reports currently contain only basic request counts tracked by the client. gRFC A51 added support for backends to report custom backend metrics to the client via the ORCA protocol. This proposal adds the ability for the client to propagate those backend metrics to the control plane in the LRS load reports.

Related Proposals:

Proposal

ORCA Integration

The gRPC xDS client will include the entire named_metrics field in ORCA load reports from the backend. They will be considered application specific opaque values with no validation.

Per-Request Support Only

Custom metrics in LRS load reports will only include named_metrics from per-request ORCA load reports and not OOB load reports. See gRFC A51 for more on per-request and OOB load reports.

Aggregation

Each per-request ORCA load report will be associated with one request for the aggregation purpose. The value and count of each entry in named_metrics will be aggregated separately. All values will be considered cumulative and will be aggregated using addition. They will be tracked at the locality level.

For example, following ORCA load reports

// report 1/3
named_metrics { key: "key1" value: 1.0 }
named_metrics { key: "key2" value: 2.0 }
// report 2/3
named_metrics { key: "key2" value: 3.0 }
named_metrics { key: "key3" value: 4.0 }
// report 3/3
// (no named_metrics)

will be aggreated to as follows.

field value number of requests
key1 1.0 1
key2 5.0 2
key3 4.0 1

LRS Load Report

The gRPC xDS client will include custom metrics in the load_metric_stats field in the locality stats. Each LRS report will include aggregated custom metrics with keys reported since the last report. Locally aggregated stats will be cleared and the associated total request counts will be reset to zero after each LRS load report is generated.

Continuing the example from the previous section, here is how the custom metric data will appear in the LRS load report:

// LRS report (envoy.service.load_stats.v3.LoadStatsRequest)
cluster_stats {
  // …
  upstream_locality_stats {
     load_metric_stats {
        metric_name: "key1"
        num_requests_finished_with_metric: 1
        total_metric_value: 1.0
     }
     load_metric_stats {
        metric_name: "key2"
        num_requests_finished_with_metric: 2
        total_metric_value: 5.0
     }
     load_metric_stats {
        metric_name: "key3"
        num_requests_finished_with_metric: 1
        total_metric_value: 4.0
     }
  }
}

xDS Integration

The xds_cluster_impl LB policy, which is already tracking call status for the client-tracked request counts, will be changed to also get the per-request backend metric data reported by the backend. It will report that data to the XdsClient along with the request counts. The XdsClient will perform aggregation of the data and include it in LRS load reports.

Implementation

This is implemented in C-core with #32690. This is implemented in Java with #10282. This is implemented in Go with #7027.